4 Commits

2 changed files with 29 additions and 13 deletions
+1 -1
View File
@@ -6,5 +6,5 @@ ldapPass here_lies_the_password
# "domain" sera ajoute a relayName pour former le FQDN # "domain" sera ajoute a relayName pour former le FQDN
domain example.org domain example.org
# Le nom de l'attribut LDAP contenant le relais a retourner # Le nom de l'attribut LDAP contenant le relais a retourner
lapAttr relayName ldapAttr relayName
+28 -12
View File
@@ -33,7 +33,7 @@ import (
) )
const ( const (
version = "0.9.8" version = "0.9.9"
// Match le nom de domaine, soit les 2 dernieres chaines separees par un point. // Match le nom de domaine, soit les 2 dernieres chaines separees par un point.
// Peut aussi terminer par un point (Ex: srv.domaine.com. => domaine.com) // Peut aussi terminer par un point (Ex: srv.domaine.com. => domaine.com)
DomainRegexpFormat = `([0-9A-Za-z\-]*)\.([0-9A-Za-z\-]*)(?:\.)?$` DomainRegexpFormat = `([0-9A-Za-z\-]*)\.([0-9A-Za-z\-]*)(?:\.)?$`
@@ -55,22 +55,38 @@ var (
timeout *int timeout *int
) )
// attempt is useless now. It was introduced to break after N attempts, but this is not implemented. Should it be?
func ldapSearch(searchReq *ldap.SearchRequest, attempt int) (*ldap.SearchResult, error) { func ldapSearch(searchReq *ldap.SearchRequest, attempt int) (*ldap.SearchResult, error) {
mutex.Lock() mutex.Lock()
result, err := conLdap.Search(searchReq) result, err := conLdap.Search(searchReq)
mutex.Unlock() mutex.Unlock()
// Let's just manage connection errors here // Let's just manage connection errors here
if err != nil && strings.HasSuffix(err.Error(), "ldap: connection closed") { if err != nil {
logstream.Err("LDAP connection closed, retrying") if strings.HasSuffix(err.Error(), "ldap: connection closed") {
mutex.Lock() logstream.Err("LDAP connection closed, retrying")
conLdap.Close() mutex.Lock()
conLdap, err = connectLdap() conLdap.Close()
mutex.Unlock() conLdap, err = connectLdap()
if err != nil { mutex.Unlock()
return result, err if err != nil {
} else { return result, err
attempt = attempt + 1 } else {
return ldapSearch(searchReq, attempt) attempt = attempt + 1
return ldapSearch(searchReq, attempt)
}
} else if err == ldap.ErrNilConnection {
logstream.Err("LDAP connection is nil, reconnecting")
mutex.Lock()
// conLdap is nil so this would be a sigsegv/panic
//conLdap.Close()
conLdap, err = connectLdap()
mutex.Unlock()
if err != nil {
return result, err
} else {
attempt = attempt + 1
return ldapSearch(searchReq, attempt)
}
} }
} }